search

grafana / scenes

Build Grafana dashboards directly in your Grafana app plugins.
https://grafana.com/developers/scenes
Apache License 2.0
141 stars 21 forks source link

Combobox: Fix "Apply" button positioning when scrolling #918

Closed ashharrison90 closed 1 month ago

ashharrison90 commented 1 month ago

before

https://github.com/user-attachments/assets/6452ea78-5601-4e5e-9a61-74bf3b9da174

after

https://github.com/user-attachments/assets/1ee53e97-b03b-43fc-96fb-f8f3ad912caf

Fixes https://github.com/grafana/hyperion-planning/issues/124

📦 Published PR as canary version: 5.16.1--canary.918.11054523232.0
:sparkles: Test out this PR locally via: ```bash npm install @grafana/scenes-react@5.16.1--canary.918.11054523232.0 npm install @grafana/scenes@5.16.1--canary.918.11054523232.0 # or yarn add @grafana/scenes-react@5.16.1--canary.918.11054523232.0 yarn add @grafana/scenes@5.16.1--canary.918.11054523232.0 ```
ashharrison90 commented 1 month ago

hmmmmm, even this doesn't fully fix the problem since the apply button doesn't reposition immediately when you type to filter the list... 😬

ashharrison90 commented 1 month ago

ok with the new changes it should work in all cases 👌

scenes-repo-bot-access-token[bot] commented 1 month ago

:rocket: PR was released in v5.16.2 :rocket: