Refresh: Improve / harden refresh url sync

grafana / scenes

Build Grafana dashboards directly in your Grafana app plugins.

https://grafana.com/developers/scenes

Apache License 2.0

141 stars 21 forks source link

Refresh: Improve / harden refresh url sync #923

Closed torkelo closed 1 month ago

torkelo commented 1 month ago

Related to https://github.com/grafana/grafana/pull/93756 where old dashboards with refresh: true would end up with refresh=true in URL which would set the auto refresh to first valid interval.

The OSS PR fixed the issue but this PR is to make sure it can't be introduced again somehow by mistake

This PR

Never add refresh to URL unless it has a value (so no longer &refresh= added to URL)
Never allow invalid interval values to set refresh to first valid valid value

scenes-repo-bot-access-token[bot] commented 1 month ago

:rocket: PR was released in v5.16.3 :rocket: