search

grafana / scenes

Build Grafana dashboards directly in your Grafana app plugins.
https://grafana.com/developers/scenes
Apache License 2.0
141 stars 21 forks source link

VariableLabel: change variable label check to OR instead of ?? #963

Closed Sergej-Vlasov closed 1 week ago

Sergej-Vlasov commented 1 week ago

Fixes https://github.com/grafana/grafana/issues/91727

How to check:

  1. create/edit variable
  2. add label and save
  3. remove label and save

Old: result blank variable label in UI. Disappears after refresh New: variable label fallbacks to variable name

Don't see any risk here to change to || instead of ??

📦 Published PR as canary version: 5.23.3--canary.963.11743338978.0
:sparkles: Test out this PR locally via: ```bash npm install @grafana/scenes-react@5.23.3--canary.963.11743338978.0 npm install @grafana/scenes@5.23.3--canary.963.11743338978.0 # or yarn add @grafana/scenes-react@5.23.3--canary.963.11743338978.0 yarn add @grafana/scenes@5.23.3--canary.963.11743338978.0 ```
scenes-repo-bot-access-token[bot] commented 1 week ago

:rocket: PR was released in v5.23.3 :rocket: