grafana / shared-workflows

A public-facing, centralized place to store reusable workflows used by Grafana Labs.
GNU Affero General Public License v3.0
9 stars 14 forks source link

fix(ci): run required checks when undrafting PRs #428

Closed iainlane closed 1 month ago

iainlane commented 1 month ago

We just merged release-please support in 023c802ae4fc29d9bc2b3428333a63f47a5dc255. The user this runs as is the default Actions bot user. One thing about this user in particular is that it doesn't trigger workflows to run. We can see that in #427 for example. At the time of writing no checks have run for that PR.

This means that its release PRs aren't actually mergeable, since we have a couple of required checks which come from Actions runs.

Fortunately we don't have to switch to an app. We can use the fact that the PRs are created in draft mode. To make a release, the process will be

  1. Make PR ready for review.
  2. Add PR to merge queue.

Workflows can be triggered by the ready_for_review activity type on the pull_request event. So they will be kicked off when a human does step 1.