search

grafana / simple-json-datasource

Datasource that sends generic http requests to give url
MIT License
509 stars 233 forks source link

Grafana 7+ fails to call /search with SimpleJSON/SimpodJSON datasources #155

Closed michaeldmoore closed 4 years ago

michaeldmoore commented 4 years ago

In all the excitement with Grafana 7+ and the move to react etc., it seems something has broken in the interface to SimpleJSON (and the enhanced SimpodJSON datasources).

I've been supporting a simple CSVServer node backend using SimpleJSON and simpodJSON for some time, so the following screencaps refer to defining a query to CSVServer, which is my named instance of the simpodJSON datasource.

Before Grafana version 7, say this sample using version 6.5, adding a query looked like this: image

On dropping down the metric selector, Grafana called the API's /search route which (in my case) returns a list of CSV files (targets) which are then displayed in the drop down. Perfect. image

Since Grafana 7.0 though, these very same datasources no longer work properly. image

Clicking the edit pencil does bring up a metric editor, of sorts: image

I've been looking at the github issues for Grafana, SimpleJSON and SimpodJSON, thinking someone must have reported this already, but I don't see anything. I think this is a bug. What stops the call to /search? and the use of the returned list of targets in the metrics selector?

Michael Moore

ivanahuckova commented 4 years ago

@michaeldmoore thanks for creating the issue. I have transferred it to grafana/simple-json-datasource repo.

michaeldmoore commented 4 years ago

Thanks for doing that. Note however, that both SimpleJSON AND the enhanced SimpodJSON data sources BOTH show the same problem, and that by just changing Grafana back to version 6.5, both data sources work perfectly. Same versions.

The problem MUST be in Grafana itself, somehow the interfaces these data sources rely on has changed. Maybe it can only be fixed by changing code in the two data sources - only your developers will know.

On Wed, Jul 22, 2020 at 9:34 AM Ivana Huckova notifications@github.com wrote:

@michaeldmoore https://github.com/michaeldmoore thanks for creating the issue. I have transferred it to grafana/simple-json-datasource repo.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/grafana/simple-json-datasource/issues/155#issuecomment-662294499, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4NLLV5X5UIFKSL52PGJWLR42JCDANCNFSM4PENI7WA .

ivanahuckova commented 4 years ago

@michaeldmoore yes, it is related to Grafana 7+ jQuery upgrade. I have created a PR that fixes this for simpleJSON https://github.com/grafana/simple-json-datasource/pull/156.