Closed wbrowne closed 10 months ago
@scottlepp I guess this warrants a new major version, right?
@wbrowne technically yes, but we don't seem too strict on doing that with breaking changes in the sdk, so not sure why we would treat this library different.
@wbrowne technically yes, but we don't seem too strict on doing that with breaking changes in the sdk, so not sure why we would treat this library different.
Fair point. I just figured since this seems to actually follow semver, might as well 🤷
this seems to actually follow semver
I think that is because this was started/maintained by a different team. Seems like it could be consistent with what the sdk does.
Due to the breaking changes in the SDK, this also adds
context.Context
to relevant places (most importantly the instance factory func) - so that sqlds plugins can be compatible