grafana / sqlds

A package that assists writing SQL-driven datasources
Apache License 2.0
17 stars 12 forks source link

adjusted handling of zero-rows results #121

Closed gabor closed 3 months ago

gabor commented 3 months ago

( fixes https://github.com/grafana/sqlds/issues/118 )

when the multi format was added, we unintentionally changed how we handle zero-rows sql-responses.. previously, for all-formats-except-timeseries, we returned the real dataframe-fields (the fields had zero items in them).

this PR adjusts the behavior to be the same as it was before. (i literally took the dataframe_test.go file, and ran it on a git-checkout of the old-version, and wrote down the results there).

NOTE: there was no format=multi in the "before" situation, so for that case, i kept the current behavior (no dataframe-fields when zero-rows).