grafana / sqlds

A package that assists writing SQL-driven datasources
Apache License 2.0
20 stars 12 forks source link

Replacing experimental errorsource.DownstreamError with backend.DownstreamError logs a different errorSource #132

Open idastambuk opened 2 months ago

idastambuk commented 2 months ago

What happened: Originally reported in https://github.com/grafana/grafana-plugin-sdk-go/pull/1087#discussion_r1763054839 We have a DownstreamError function in both the experimental package and backend package. However, if I replace the experimental one with the backend one, the error doesn't have the errorSource marked as downstream anymore (but the error string is prepended with downstream error). Image Image

Looks like we overwrite the source: https://raintank-corp.slack.com/archives/C068FL57F0V/p1726590417646519?thread_ts=1726590100.558479&cid=C068FL57F0V What you expected to happen:

for the errorSource to be "downstream"

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment: