Bug fixes / context refactor

grafana / sqlds

A package that assists writing SQL-driven datasources

Apache License 2.0

17 stars 12 forks source link

Closed kminehart closed 3 years ago

kminehart commented 3 years ago

Fixes #16

Before:

After:

Also includes fixes:

No more using github.com/pkg/errors, instead we just use the standard library errors package with fmt.Errorf.
- fixes #31
Adds context and context.WithTimeout to allow drivers to define a timeout based on the data source settings.
- fixes #28

This does include a breaking change because of the new function on the interface.

kminehart commented 3 years ago

LGTM. I'd be great to have more tests but don't want to block this PR for that.

I'm with you but I think I want to do some refactoring to make this more testable first :see_no_evil: