andresmgot
commented
3 years ago Maybe it's worth continuing the discussion. I'm skeptical that any kind of default macro is going to work for every database.
I wonder if all databases even support comparing times with > or <.
Perhaps for those that don't, they could overwrite the key in the DefaultMacros map? If that's a possible use case we should document that :)
Yes, my intention here is to add macros that work in most databases (for example the > or < operand is valid for all the databases that use sqlds at the moment) but they can be overwritten by the datasources (and that would be the most common case for macros like $__timeGroup). In the tests there is an example of how to override a macro, they just need to re-define it:
Fixes #43
I have added default macros and a suggested implementation (that should work for any SQL server). It's expected from the data sources to re-implement them if necessary, to adjust to their needs.
The goal is to set a common ground so all the SQL datasources implement at least a common set of macros following the pattern defined here.