search

grafana / sqlds

A package that assists writing SQL-driven datasources
Apache License 2.0
18 stars 12 forks source link

Update Completable interface with custom options #47

Closed andresmgot closed 3 years ago

andresmgot commented 3 years ago

Fixes #46

Note that this is a breaking change since the Completable interface has different parameters but the only datasources that use them are the ones I maintain (so I will change them after this PR). Do you think we should bump the major version anyway?

andresmgot commented 3 years ago

Note that this is a breaking change since the Completable interface has different parameters but the only datasources that use them are the ones I maintain (so I will change them after this PR). Do you think we should bump the major version anyway?

I'm going to go ahead and release v2.3 (rather than a major) so people don't need to change the import path and everything.