search

grafana / synthetic-monitoring-agent

Synthetic Monitoring Agent
https://grafana.com/docs/grafana-cloud/how-do-i/synthetic-monitoring/
Apache License 2.0
155 stars 20 forks source link

Fix .github/renovate.json #750

Closed mem closed 3 days ago

mem commented 1 week ago

Documentation says I should use these options, renovate says I shouldn't. I guess renovate knows better.

mem commented 6 days ago

renovate doesn't work without (some) of this options...

ka3de commented 5 days ago

There is a conflict due to forkProcessing being disabled in #751. I will approve this once that's fixed.

roobre commented 4 days ago

Documentation says I should use these options, renovate says I shouldn't. I guess renovate knows better. renovate doesn't work without (some) of this options...

Self-hosted renovate typically has two configuration files, one for renovate itself, which configures things like authentication, and another one for each repo that renovate manages.

With this setup of running renovate inside CI, which is not the usual way of running it, we're blurring the line a bit because we're running one renovate instance per repo. username, platform, and repositories are configs for renovate itself and not for the repo, so the bot is probably reading those in repo context and getting a bit confused.

I think the proper way to fix this is to split the configuration in two as renovate expects it. username, platform, and repositories should be on a different file referenced here: https://github.com/grafana/synthetic-monitoring-agent/blob/d798772b1fb616d7aead242325458035f057b53e/.github/workflows/renovate.yaml#L26

And that file should be different from the file in default paths for the repo config, which contains the rest of the config.

roobre commented 3 days ago

I've split the config files as renovate wants them here: https://github.com/grafana/synthetic-monitoring-agent/pull/767/files

mem commented 3 days ago

Merged #767 that actually fixes this.

Thanks, @roobre