grafana / synthetic-monitoring-agent

Synthetic Monitoring Agent
https://grafana.com/docs/grafana-cloud/how-do-i/synthetic-monitoring/
Apache License 2.0
156 stars 22 forks source link

Default to `sm-k6` binary instead of `k6` #782

Closed roobre closed 1 month ago

roobre commented 1 month ago

As described in: https://github.com/grafana/support-escalations/issues/11346#issuecomment-2213578649

For non-docker installations, we ship a sm-k6 binary with the required sm extension that we must use. However, this binary is never looked up, and instead we default to a k6 binary in the system which may not have the required extension, resulting in obscure failures with exit code 255.

This PR changes the default value to sm-k6, and adjusts the Dockerfile so the k6 binary is copied inside with this name.

https://github.com/grafana/synthetic-monitoring-agent/compare/look-sm-k6-first is an alternative to this, but I'm leaning towards this impl for simplicity.