search

grafana / synthetic-monitoring-app

Synthetic Monitoring frontend application
https://grafana.com/docs/grafana-cloud/how-do-i/synthetic-monitoring/
GNU Affero General Public License v3.0
145 stars 19 forks source link

Validation of browser and scripted checks #864

Open peterschretlen opened 3 months ago

peterschretlen commented 3 months ago

With the introduction of browser & scripted checks, we want to enforce that the code matches the type of check that is selected

What happens if you add this to a scripted check?

import { browser } from 'k6/browser' // or 'k6/experimental/browser';

What happens if you fail to include it in a browser check?

There may be both FE and BE validation needed here, but it would be preferable to validate in the editor rather than when a script is tested or saved.

VikaCep commented 2 months ago

The frontend validation has been implemented here https://github.com/grafana/synthetic-monitoring-app/pull/869. Not sure if we also want to add backend validation or we can close the issue.

peterschretlen commented 2 weeks ago

This is coupled to supporting archives