search

grafana / tanka

Flexible, reusable and concise configuration for Kubernetes
https://tanka.dev
Apache License 2.0
2.3k stars 164 forks source link

`tk export` broken on Windows #1055

Open systemtrap opened 1 month ago

systemtrap commented 1 month ago

Since #841 tk export breaks on Windows.

godirwalk changed its behavior in karrick/godirwalk#68. godirwalk seems unmaintained as karrick/godirwalk#70 is an open issue for more than a year.

zerok commented 1 month ago

Thank you for reporting this 🙂

Judging by the code that uses godirwalk the reason for adding it was performance implications of filepath.Walk. IMO it would be worth a try to benchmark the current implementation against one using filepath.WalkDir and switch to that if they are at least comparable.

zerok commented 1 month ago

@systemtrap if you have the time, could you perhaps please try https://github.com/grafana/tanka/pull/1058 if that works for you?