search

grafana / tanka

Flexible, reusable and concise configuration for Kubernetes
https://tanka.dev
Apache License 2.0
2.35k stars 166 forks source link

custom-metrics-stackdriver-adapter preventing diff to work #1076

Closed zerok closed 1 month ago

zerok commented 2 months ago

(Based on a report through a different channel)

custom-metrics-stackdriver-adapter can return an empty response that is handled by k8s.io/client-go <= 0.25 in a fatal way and > 0.25 by just logging the issue and returning an empty list.

Running tk diff in such a scenario leads to the following error:

error: unable to retrieve the complete list of server APIs: external.metrics.k8s.io/v1beta1: received empty response for: external.metrics.k8s.io/v1beta1
Error: listing known api-resources: exit status 1

Tested in 0.27.1 with kubectl 1.29.5.

There exists an issue for this in the k8s-stackdriver project as this is causing issues also with helm and possibly other tools: https://github.com/GoogleCloudPlatform/k8s-stackdriver/issues/729

zerok commented 1 month ago

Upstream now seems to have a fix 🙂 If anyone is running into the issue above could you please try this update (once released) and let us know if that fixes it for you? Thanks!

mal-berbatov-ci commented 1 month ago

Can confirm that version 0.15.1-gke.0 fixes this.

zerok commented 1 month ago

Awesome, thank you for checking 😄