search

grafana / tanka

Flexible, reusable and concise configuration for Kubernetes
https://tanka.dev
Apache License 2.0
2.36k stars 167 forks source link

wrong env path #79

Closed daixiang0 closed 4 years ago

daixiang0 commented 4 years ago 
[root@test config]# tk env add loki --namespace loki
[root@test config]# ls environments/
default
[root@test config]# tk env list
NAME       NAMESPACE    SERVER    
default    default                
loki       loki   
[root@test config]# ls
environments  jsonnetfile.json  lib  loki  vendor
[root@test config]# ls loki/
main.jsonnet  spec.json

The new env dir should under environments.

issue-label-bot[bot] commented 4 years ago

Issue-Label Bot is automatically applying the label kind/bug to this issue, with a confidence of 0.97. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

sh0rez commented 4 years ago

Hi, this is actually working as intended, because Tanka is not opinionated about where an environment should live. Instead, every directory with a main.jsonnet is a valid one, regardless of where it is placed. The environments/ folder is only a recommendation and does not need to be used.

Furthermore, tk always uses full folder paths to allow them being tab-completed

daixiang0 commented 4 years ago

If it marked in doc or command help, it would be good! @sh0rez

Also, the env only mean a config set of main/spec, right? If i install many app in same env, how it work? replace main/spec?