grafana / tempo-operator

Grafana Tempo Kubernetes operator
https://grafana.com/docs/tempo/latest/setup/operator/
GNU Affero General Public License v3.0
61 stars 30 forks source link

Kubernetes 1.30 enablement #1031

Closed oscar-izval closed 1 month ago

oscar-izval commented 1 month ago

Enabling operator tests to run on Kubernetes 1.30. Referencing the work of https://github.com/grafana/tempo-operator/pull/807.

Closes #1030

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.08%. Comparing base (36805bb) to head (c50c66b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1031 +/- ## ======================================= Coverage 73.08% 73.08% ======================================= Files 106 106 Lines 6624 6624 ======================================= Hits 4841 4841 Misses 1493 1493 Partials 290 290 ``` | [Flag](https://app.codecov.io/gh/grafana/tempo-operator/pull/1031/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grafana) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/grafana/tempo-operator/pull/1031/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grafana) | `73.08% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grafana#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

andreasgerstmayr commented 1 month ago

Thank you!

oscar-izval commented 1 month ago

Thanks for the quick response @andreasgerstmayr! Btw, this page should probably reflect the changes too :) https://grafana.com/docs/tempo/next/setup/operator/#kubernetes

andreasgerstmayr commented 1 month ago

Thanks for the quick response @andreasgerstmayr! Btw, this page should probably reflect the changes too :) https://grafana.com/docs/tempo/next/setup/operator/#kubernetes

Yes. I wonder if we should add a table to the README of this repo, and link to this table from the Grafana docs instead of always needing to update the Grafana docs.

Maybe a table like this: Tempo Operator Kubernetes Tempo
v0.13.0 v1.25 to v1.29 v2.5.0

Similar to the table in the opentelemetry-operator at https://github.com/open-telemetry/opentelemetry-operator?tab=readme-ov-file#opentelemetry-operator-vs-kubernetes-vs-cert-manager-vs-prometheus-operator wdyt @pavolloffay?