Open yvrhdn opened 2 years ago
This issue has been automatically marked as stale because it has not had any activity in the past 60 days. The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed after 15 days if there is no new activity. Please apply keepalive label to exempt this Issue.
Hi @kvrhdn, It looks like this issue is stale now.
search_enabled
, metrics_generator_enabled
flags were removed from tempo a while back.
Only multitenancy_enabled
is left and it's a top level flag already
Yeah, features come and go. Search and metrics-generator are now enabled by default, we had another temporary flag autocomplete_filtering_enabled
that very recently got removed.
I think the original request of putting these flags in a features
section is still fine though, we just don't really care enough about it to do the breaking changes.
Is your feature request related to a problem? Please describe. Tempo is gradually gaining optional features/components that can be enabled/disabled globally. We already have
search_enabled
and https://github.com/grafana/tempo/pull/1282 addsmetrics_generator_enabled
.These toggles control major features usually impacting multiple components.
Describe the solution you'd like To make it easier to find these toggles we can group them in a global section
features
, i.e.:Describe alternatives you've considered We can just not do this and keep the status quo:
Or move them all to the top-level:
This is probably fine for now but might become impractical if we add many toggles 🤷🏻
Additional context