search

grafana / tempo

Grafana Tempo is a high volume, minimal dependency distributed tracing backend.
https://grafana.com/oss/tempo/
GNU Affero General Public License v3.0
3.76k stars 488 forks source link

Proposal: Move `tempo-distributed` helm chart to `tempo` repo #2113

Open zalegrala opened 1 year ago

zalegrala commented 1 year ago

It used to be that most (all?) of the helm charts for Grafana Labs were maintained out of the helm-charts repo, but in the last year, several of these charts have moved out to the respective projects. For those projects, the helm-charts repo continues to be the place that the charts are published, and some of the CI in the helm-charts repo is still in use to facilitate publishing the artifacts. However, the ongoing issues/PRs and maintenance are run out of the project repos.

Anecdotally I've head that this has helped the teams pay more attention to the charts that perhaps were not getting the attention they deserved. Additionally, since the Jsonnet deployment mechanisms are also run out of those repositories, comparisons between Jsonnet and Helm become a little more feasible, and some teams are working to keep those two deployment methods in general sync with one another.

I think the primary reason for the Tempo team to consider following in the footsteps of the other teams is uniformity in approach, which will likely help folks in and out of the company make assumptions (and be mostly correct) about how the Tempo team operates, with respect to other backend databases and their Helm usage.

Here are some handy links that we might be able to mostly copy from the Mimir team's CI for handling the Helm chart and help us move forward.

Docs Weekly release pr CI Release

I believe the technical work is mostly implementing the above Github workflows. There may be an auth token required somewhere that we'll need to figure out. Also, we'll want to let the community know. I'm not sure what maintainership looks like post-move, and so we'll want to keep community folks in the loop who are current maintainers of the Tempo chart.

I'd love to hear thoughts or counter-proposals, or feedback from the community or Grafana folks about this. I wanted to write this up so that we had something around which to form the discussion.

joe-elliott commented 1 year ago

I am generally supportive of this effort if the relevant stakeholders are on board. We need to make sure this is well communicated and issues filed against the grafana/helm-charts repo are still caught by Tempo developers.

Also, @faustodavid and others who have contributed regularly to the helm chart need to be brought into the Tempo as codeowners as well. These engineers need to be recognized for their continued work on the project. I will leave this distinction up to @zalegrala.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed after 15 days if there is no new activity. Please apply keepalive label to exempt this Issue.

github-actions[bot] commented 8 months ago

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed after 15 days if there is no new activity. Please apply keepalive label to exempt this Issue.

sentoz commented 7 months ago

Hello! Tell me, is there any movement expected on this issue?

zalegrala commented 7 months ago

:wave: I would not expect movement on this before the end of the year. Please send all issues and PRs to the helm-charts repo. Feel free to mention me on issues if you wish, but I will also get notified for changes in that repo.

Starefossen commented 3 months ago

Picking this up. This would be nice in order to keep the chart in sync with tempo releases and also have one place for tempo related issues.