[DOCS] Missing `metrics_generator.traces_storage`, `metrics_generator.query_timeout` and `metrics_generator.override_ring_key`

grafana / tempo

Grafana Tempo is a high volume, minimal dependency distributed tracing backend.

https://grafana.com/oss/tempo/

GNU Affero General Public License v3.0

3.93k stars 509 forks source link

[DOCS] Missing `metrics_generator.traces_storage`, `metrics_generator.query_timeout` and `metrics_generator.override_ring_key` #3642

Closed WesselAtWork closed 2 months ago

WesselAtWork commented 5 months ago

Noticed that some keys are missing in the documentation for the complete configuration.

https://github.com/grafana/tempo/blob/251bf5a9a74fd586ffd3dedcc2c8000f36aa9a78/modules/generator/config.go#L27-L36

https://github.com/grafana/tempo/blob/251bf5a9a74fd586ffd3dedcc2c8000f36aa9a78/docs/sources/tempo/configuration/_index.md?plain=1#L286-L412

joe-elliott commented 5 months ago

Thanks for the heads up!

derek-cadzow commented 5 months ago

Assigning to myself so that it can be reassigned to our new Mimir writer when she has started and is on board.

knylander-grafana commented 4 months ago

@derek-cadzow, this is a Tempo configuration for the metrics-generator, a component used in Tempo to generate metrics from traces. @WesselAtWork has an excellent doc PR to update the metrics-generator doc (#3643).

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed after 15 days if there is no new activity. Please apply keepalive label to exempt this Issue.