search

grafana / tempo

Grafana Tempo is a high volume, minimal dependency distributed tracing backend.
https://grafana.com/oss/tempo/
GNU Affero General Public License v3.0
3.76k stars 488 forks source link

Missing common.proto and trace.proto #3666

Open XiangFrank opened 1 month ago

XiangFrank commented 1 month ago

Describe the bug In the pkg/tempopb/tempo.proto file, it import common.proto and trace.proto, these two files are supposed to be under /pkg/tempopb/common/v1 and /pkg/tempopb/trace/v1, but they are missing.

I suppose they should be the same to the OpenTelemetry proto common.proto and trace.proto, but still wanna confirm it and possibly add them back to avoid confusion.

To Reproduce Steps to reproduce the behavior:

  1. Start Tempo (SHA or version)
  2. Perform Operations (Read/Write/Others)

Expected behavior

Environment:

Additional Context

joe-elliott commented 1 month ago

Yup. We have a somewhat convoluted process to generate proto in the repo. Run make gen-proto from the root to create those files.