grafana / tempo

Grafana Tempo is a high volume, minimal dependency distributed tracing backend.
https://grafana.com/oss/tempo/
GNU Affero General Public License v3.0
3.93k stars 509 forks source link

Filters not working for Span Name #3778

Closed tg3rh closed 1 month ago

tg3rh commented 3 months ago

Describe the bug When applying the a filter for the Span Name, it does not seem to be applied/recognized.

To Reproduce Steps to reproduce the behavior:

  1. Navigate to the Explore section in Grafana
  2. Navigate to Query type: Search
  3. Select a Span Name and filter to exclude it
  4. Run query and check results, these are still included

Expected behavior Expecting these traces to be excluded from the list below.

Environment:

Additional Context Attaching screenshots for reproduction. Screenshot 2024-06-17 at 08 18 36 Screenshot 2024-06-17 at 08 22 35

joe-elliott commented 3 months ago

The TraceQL query you are constructing:

{ resource.service.name="spring-boot-redis" && name!="GET /api/users/{id}"}

will find spans that match these criteria. What you have circled is the name of the root span of a trace and not the span that matched the search. Use the drop down arrow to the left to find the spans that matched your search conditions.

tg3rh commented 3 months ago

Thanks for the speedy response @joe-elliott! So might this be a bug related to selection menu? As this TraceQL query that was constructed is generated from the selection menu above, where I could choose the suggested Span Name (screenshot 1).

joe-elliott commented 3 months ago

So might this be a bug related to selection menu?

This is a misunderstanding of what the query is asking for and what the results are telling you.

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed after 15 days if there is no new activity. Please apply keepalive label to exempt this Issue.