grafana / tempo

Grafana Tempo is a high volume, minimal dependency distributed tracing backend.
https://grafana.com/oss/tempo/
GNU Affero General Public License v3.0
4.06k stars 524 forks source link

[DOC] Update overrides content in Helm chart to clarify configuration for new, legacy #3820

Open knylander-grafana opened 5 months ago

knylander-grafana commented 5 months ago

Update the overrides configuration documentation to address changes to the Overrides module. The configuration examples need to be checked to make sure they are for the updated overrdies and which ones are not.

Update these pages:

The configuratio file in this doc works, but it's a YAML file: "A snippet of a config.yaml file showing how the overrides section is here.

Reference: https://github.com/grafana/tempo/issues/3795, https://github.com/grafana/helm-charts/issues/2802#issuecomment-2461246589

Notes

Same issue happens in the tempo-distributed Helm chart:

global_overrides:
  defaults:
    metrics_generator:
      processors:
        - span-metrics
      processor:
        span_metrics:
          histogram_buckets: [null]
          dimensions:
            - kubernetes_cluster
            - kubernetes.cluster
            - http.status_code

As a rule of thumb: long, unindented params are legacy (eg. metrics_generator_forwarder_queue_size), indented params are new (eg. metrics_generator.forwarder.queue_size).

With the new config, a new key defaults was also added after the overrides key, to be more explicit of the contents of the config block.

Finally, there is a command in the tempo-cli that allows you to convert legacy config to new overrides config.

github-actions[bot] commented 3 months ago

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed after 15 days if there is no new activity. Please apply keepalive label to exempt this Issue.

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed after 15 days if there is no new activity. Please apply keepalive label to exempt this Issue.

knylander-grafana commented 2 hours ago

Mario found an issue in the tempo-distributed Helm chart that prevented the overrides examples from working. The issue was corrected in this PR: https://github.com/grafana/helm-charts/pull/3236

knylander-grafana commented 2 hours ago

There is an issue in the Helm chart that needs to be fixed. Outlined here: https://github.com/grafana/helm-charts/issues/2802#issuecomment-2461246589

The tempo-distributed Helm chart doesn't have the same implementation of the overrides as the standard Tempo configuration. The per tenant overrides is being implemented with the global overrides. The docs are correct, but how the overrides are implemented in the Helm chart is slightly different. We should update the tempo-distributed Helm chart documentation with a work around until this