grafana / tempo

Grafana Tempo is a high volume, minimal dependency distributed tracing backend.
https://grafana.com/oss/tempo/
GNU Affero General Public License v3.0
4.05k stars 524 forks source link

Tempo dashboards often lack detail #895

Open bboreham opened 3 years ago

bboreham commented 3 years ago

Describe the bug Rates are using a [4m] window. This stems from here: https://github.com/grafana/tempo/blob/eabe781c0f0985b0835c6c7472d8d0be1144c82f/operations/tempo-mixin/dashboard-utils.libsonnet#L38 coupled with the use of [$__rate_interval] which is floored at 4x interval. E.g. https://github.com/grafana/tempo/blob/c865ea8a41b7c5cb26862302390aa13f55e123c5/operations/tempo-mixin/yamls/tempo-operational.json#L612

To Reproduce Bring up a Tempo dashboard, e.g.: image

Expected behavior with minimum edited to 15s: image

Environment: N/A

Additional Context There are also lots of rate(...[$__interval]), so in the dashboards, which would then have a too-small interval if we just changed the one line at the top. $__rate_interval should be used throughout.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed after 15 days if there is no new activity. Please apply keepalive label to exempt this Issue.