search

grafana / terraform-provider-grafana

Terraform Grafana provider
https://www.terraform.io/docs/providers/grafana/
Mozilla Public License 2.0
422 stars 225 forks source link

[Feature Request]: Support for Extended Durations in wait step in Grafana OnCall Provider #1733

Open Axel-sys-777 opened 1 month ago

Axel-sys-777 commented 1 month ago

Feature Request

Currently, the Grafana OnCall Terraform Provider supports duration values of 60, 300, 900, 1800, and 3600 seconds (up to 1 hour). This request is to extend the maximum allowable duration to support longer wait times, ideally up to 24 hours (86400 seconds).

Use Case: In many operational scenarios, particularly in incident management and escalation processes, it is often necessary to define wait steps that extend beyond the current 1-hour limit. Extending the duration support to 24 hours would provide greater flexibility and enable more comprehensive incident management workflows.

Proposed Solution: Modify the Grafana OnCall Terraform Provider to support duration values up to 86400 seconds (24 hours).

Thank you very much.

Hackmeat commented 1 month ago

Important feature, especially because the ui it self already allows 24 hours. Would love so see the implementation for this!

julienduchesne commented 1 month ago

👋 Can you screenshot your UI? From what I can see, OnCall doesn't support longer than 60 minutes

Hackmeat commented 1 month ago
Screenshot 2024-08-01 at 09 35 48

Any value is applicable in the ui and also works in the chains - just the provider doesn't allows you to push anything higher than 60 minutes.

From my point of view it would be more logical to have time ranges instead of pre defined values.

The Oncall Code als suggests the Values are not capped to the suggested values

if step == "wait":
    step = "{}({})".format(p["type"], p["duration"])