search

grafana / thema

A CUE-based framework for portable, evolvable schema
Apache License 2.0
229 stars 12 forks source link

Goreleaser #180

Closed spinillos closed 1 year ago

spinillos commented 1 year ago

Adds Goreleaser to generate semantic versioning to thema.

Contributes to: https://github.com/grafana/thema/issues/172

sdboyer commented 1 year ago

thanks!

sdboyer commented 1 year ago

Hmm, there seems to be an issue with the tag regex: https://github.com/grafana/thema/actions/runs/5713950449. Annoying that the actions engine only complained after merging...

But, it's not immediately obvious to me why that's a problem, as the regex itself is valid. @spinillos could you investigate and fix?

joanlopez commented 1 year ago

Hmm, there seems to be an issue with the tag regex: https://github.com/grafana/thema/actions/runs/5713950449. Annoying that the actions engine only complained after merging...

But, it's not immediately obvious to me why that's a problem, as the regex itself is valid. @spinillos could you investigate and fix?

Seems related with: https://github.com/orgs/community/discussions/55854 TL;DR: Looks like it has no full regex capabilities.

So, I guess we'll need to either simplify it or find an alternative. After a very quick search, I've found a Parse Semver action, which I guess could help to define a conditional workflow.