cmd/unused: refactor UI.Display to accept UI options - Githubissues

grafana / unused

CLI tool, Prometheus exporter, and Go module to list your unused disks in all cloud providers

Apache License 2.0

51 stars 1 forks source link

cmd/unused: refactor UI.Display to accept UI options #14

Closed inkel closed 2 years ago

inkel commented 2 years ago

Currently we have two UI options:

verbose mode enabled
additional columns to show

But the ui.UI defines only one method: Display(ctx context.Context, disks unused.Disks, extraColumns []string) error. Here clearly the verbose mode option is missing, and we're relying on passing that to the different ui.UI implementation constructors.

In the future we also might introduce more UI options, so let's do the following changes:

add a ui.Options or similar struct to hold these configurations
change UI.Display signature to something like Display(context.Context, ui.Options, unused.Disks) error

inkel commented 2 years ago

This was addressed in #19.