search

grafana / unused

CLI tool, Prometheus exporter, and Go module to list your unused disks in all cloud providers
Apache License 2.0
51 stars 1 forks source link

Output additional information about the disks #45

Closed Pokom closed 1 year ago

Pokom commented 1 year ago

It would be helpful to output additional information about the disk that is not available via the kubernetes metadata properties. I am specifically looking to see the disk type(SSD vs regular) and size.

These fields will likely grow over time, so it may be useful to have a similar functionality as extraColumns. The only issue with extra columns is it appears to be coupled to kubernetes metadata.

I have an initial implementation in #44 and would be more then happy to share the results.

inkel commented 1 year ago

I like this idea very much.

I think I'd leave -add-column for picking stuff from the disks metadata, and instead add new boolean flags (defaulting to true or false depending on how useful they are to have all the time, and always true when -v (verbose) is used) for the these, something like:

What do you think?

Pokom commented 1 year ago

I like it in theory, I just get a bit concerned about how it impacts the readability of the code. I'd need to see what that looks like implementation wise.

How would you feel about separating the flags to separate issue so?

inkel commented 1 year ago

How would you feel about separating the flags to separate issue so?

Oh, definitely. Let's just add these by default all the time, we can work output customization later.