search

grafana / vscode-jsonnet

Full code support (formatting, highlighting, navigation, etc) for Jsonnet
Apache License 2.0
66 stars 7 forks source link

problems: No errors or warnings #7

Closed unional closed 2 years ago

unional commented 2 years ago

When I open a file, e.g. qa.jsonnet, it adds a entry in the Problems panel saying "No Errors or warnings"

Is this expected? thx

julienduchesne commented 2 years ago

Hey, it's expected but not ideal. When I last tested this, sending no diagnostics didn't clear previous errors, so I added this info: https://github.com/grafana/jsonnet-language-server/blob/fa0afc7ebea6462d3083342e4ba61918044ce303/pkg/server/diagnostics.go#L79-L87 to the language server so that errors would be cleared when resolved

I'm due to revisit this, other language servers do not have this issue so there must be something I'm doing wrong. I'll look into it 👀

julienduchesne commented 2 years ago

Should be fixed with https://github.com/grafana/jsonnet-language-server/releases/tag/v0.7.2