search

grafana / worldmap-panel

Worldmap panel plugin for Grafana 3.0 that can be overlaid with circles for data points.
MIT License
309 stars 199 forks source link

Adds clickthrough links mappable from data for circles #190

Closed lha-wd closed 5 years ago

lha-wd commented 5 years ago

Hello everybody.

First of all great job on the panel.

I was missing the functionality of having a link for each of the generated circles based on the datasource-entries.

A textbox is now added, which can be used to specify the columnname (on table data) containing the link.

The link is then used to add an onclick listener to the circle. I used code-fragments from PR #129 for this.

If the link is empty for some reason (for example: no link in datasource) the onclick listener will not be created.

I was only able to test it properly with MSSQL so any hints at problems with other datasources are welcomed.

With best regards, Leo

amotl commented 5 years ago

Dear @leonhardhaas,

thanks for sharing your work on this. While revisiting this topic from time to time, we just found your recent implementation based on top of #129, which was the most prominent candidate for us until now.

I was only able to test it properly with MSSQL so any hints at problems with other datasources are welcomed.

While we haven't run this yet, we are definitively looking forward. As we are running InfluxDB, we will report about our findings in this regard.

With kind regards, Andreas.

amotl commented 5 years ago

Dear Leonhard,

we cherry-picked your improvements into our working branch at [1], wrote about this and further updates at [2] and just announced the outcome at [3], which you might also be interested in. Thanks a bunch for sharing your efforts.

With kind regards, Andreas.

[1] https://github.com/hiveeyes/grafana-worldmap-panel [2] https://community.grafana.com/t/giving-the-grafana-worldmap-panel-some-love/17210 [3] https://community.hiveeyes.org/t/grafana-worldmap-panel-0-3-0-dev-series/1824

lha-wd commented 5 years ago

Hello Andreas.

Thanks for the update and the consideration of adding my changes into your working branch.

With best regards, Leo

amotl commented 5 years ago

So, we might close this PR, right? I believe @fabienpomerol will be doing the same with #156. As @daniellee and others are pretty busy with other things, they probably will appreciate the community self-maintaining this ;].

However, he recognized the whole bunch of improvements already and might review them when he will find some time for that in order to bring the changes into mainline.