search

grafana / worldmap-panel

Worldmap panel plugin for Grafana 3.0 that can be overlaid with circles for data points.
MIT License
312 stars 199 forks source link

leaflet.js out of date and throwing exception #199

Open briangann opened 5 years ago

briangann commented 5 years ago

the current version of leaflet in lib is out of date (1.0.3), should be updated to 1.4.0

console output is showing:

leaflet.js:12075 Uncaught TypeError: Cannot read property 'clearRect' of undefined
    at e._clear (leaflet.js:12075)
    at e._redraw (leaflet.js:12065)
Lexycon commented 5 years ago

Same here, any news about this? Maybe a workaround?

amotl commented 5 years ago

Dear Brian,

it looks like the Worldmap Panel is using Leaflet 1.3.1 already [1]. I might attempt to upgrade to the most recent Leaflet version at our development branch at [2], where we improved some other things already [3,4].

Saying that, we never have been able to spot the exception you are referencing while getting more involved with the Worldmap Panel.

With kind regards, Andreas.

[1] https://github.com/grafana/worldmap-panel/blob/master/src/libs/leaflet.js#L3 [2] https://github.com/hiveeyes/grafana-worldmap-panel [3] https://community.grafana.com/t/giving-the-grafana-worldmap-panel-some-love/17210 [4] https://community.hiveeyes.org/t/grafana-worldmap-panel-ng/1824