grafana / worldmap-panel

Worldmap panel plugin for Grafana 3.0 that can be overlaid with circles for data points.
MIT License
309 stars 199 forks source link

Merge changes from hiveeyes and use toolkit #214

Open ryantxu opened 5 years ago

ryantxu commented 5 years ago

This is a PR from my toolkit work on hiveeyes. To actually merge it we should:

maybe first commit a change to worldmap that removes dist so the PR is not so large

torkelo commented 5 years ago

It's a bit scary to merge this when it comes with so many new features and options that we have to support going forward, would require more testing as well to see if this breaks any existing dashboards.

But most importantly it does not fix the issue for me. image

Would be nice to isolate the upgrade to grafana toolkit

ryantxu commented 5 years ago

It's a bit scary to merge this

Ya -- it is essentially the fork that has been getting more constant attention for the last year while the core plugin has not moved.

Merging toolkit changes first is hard since then most things are formatting issues :(

My main thought/concern about the work in worldmap-panel-ng is that most of it is adding better support for table data. This should all be moot with DataFrames, but either approach merging or converting to DataFrames will require some love and attention

amotl commented 5 years ago

Dear @torkelo and @ryantxu,

thanks for giving our fork some attention. We very much appreciate the care you are giving to it regarding toolkit support and probably more, @ryantxu.

We see the change against upstream is pretty large already and we would also like to give this some more intense testing. Especially @smargo171's input on https://github.com/hiveeyes/grafana-worldmap-panel/issues/10 would be worth to follow up on before considering going mainline.

Adding better support for table data should all be moot with DataFrames, but either approach merging or converting to DataFrames will require some love and attention.

While currently a bit swamped which prohibits immediate diving into the topic and codebase again, I would love to hear more about the DataFrames you mentioned here. Is it a new internal data carrier essentially making the wrestling with table format vs. timeseries format things obsolete at all?

Depending on which time frame you are looking at, I might be able to pick up our work on Worldmap NG, give it some more love and check its robustness on some edges.

Unfortunately, we haven't been able to dedicate ourselves to #213, so thanks a bunch for fixing that!

Please let me know / try to apply some pressure if you see that we can support you in the process of bringing the code base back to mainline again.

With kind regards, Andreas.

CLAassistant commented 3 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 6 committers have signed the CLA.

:x: ryft
:x: leonhardhaas
:x: fabienpomerol
:x: ryantxu
:x: amotl
:x: dtheb
You have signed the CLA already but the status is still pending? Let us recheck it.