search

grafana / worldmap-panel

Worldmap panel plugin for Grafana 3.0 that can be overlaid with circles for data points.
MIT License
309 stars 199 forks source link

Switch for dragging enabled #251

Closed gdunstone closed 4 years ago

gdunstone commented 4 years ago

The panel creates issues when navigating on mobile.

I tried to fix this myself and put a pull request in but wasn't able to work out how to get the panel with my changes into a test Grafana instance to test whether my changes actually worked. The commit for the changes is here: https://github.com/gdunstone/worldmap-panel/commit/66da5b5bb6cc0babc7b61a69d812fb904fff5b84

It passed the tests, but I wasn't able to test whether the change actually functions.

gdunstone commented 4 years ago

Actually it seems like my changes should work according to the leaflet documentation, so ill open a pull request.

amotl commented 4 years ago

Dear Gareth,

thanks for your contribution! We will also be happy to receive a corresponding pull request like #252 against the fork [1,2] we are actively maintaining. You might also like the additional features you will gain from that.

With kind regards, Andreas.

[1] https://github.com/panodata/grafana-map-panel [2] https://community.panodata.org/t/grafana-map-panel/121

gdunstone commented 4 years ago

Thanks. I'll open the pull request there.