search

grafana / worldmap-panel

Worldmap panel plugin for Grafana 3.0 that can be overlaid with circles for data points.
MIT License
305 stars 201 forks source link

Data: Adds support for the wide data frame format #318

Closed hugohaggmark closed 2 years ago

hugohaggmark commented 3 years ago

This PR is an intermediate solution for https://github.com/grafana/grafana/issues/35599 until we have a better, and more generic solution in place.

Fixes #https://github.com/grafana/grafana/issues/35599

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

ryantxu commented 3 years ago

This has a ton of formatting changes that are not required (or applied automatically) by the plugin settings -- can we either exclude the formatting changes, or split this into two PRs -- one for formatting and another for the wide support. I am kinda reluctant to change the supported formats here -- this plugin is super fragile anyone trying anything too complicated should use https://github.com/panodata/grafana-map-panel

hugohaggmark commented 3 years ago

This has a ton of formatting changes that are not required (or applied automatically) by the plugin settings -- can we either exclude the formatting changes, or split this into two PRs -- one for formatting and another for the wide support. I am kinda reluctant to change the supported formats here -- this plugin is super fragile anyone trying anything too complicated should use https://github.com/panodata/grafana-map-panel

Sure, valid point. I'll revert the formatting changes.

hugohaggmark commented 3 years ago

@ryantxu removed all the formatting

ryantxu commented 2 years ago

With https://github.com/grafana/grafana/pull/36737 I don't think this is still necessary

hugohaggmark commented 2 years ago

Closing this in favor of grafana/grafana#36737