search

grafana / worldmap-panel

Worldmap panel plugin for Grafana 3.0 that can be overlaid with circles for data points.
MIT License
310 stars 199 forks source link

Adding minimum value filtering and dual metric, using circle sizes and colours for different metrics. #327

Open eduelias opened 3 years ago

eduelias commented 3 years ago

Adding two new functionalities:

1) Filtering data points with value lower than a number, set up on the editor screen.

2) Using colour as a second metric, enabling the map to show two different metrics, like total bought pizzas and complaints, or sessions and errors.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

amotl commented 3 years ago

Dear Eduardo,

this patch is very valuable. Thanks a stack for sharing it with the community.

For your records, Grafana Labs will probably move on to integrate the new "Geomap panel" into Grafana core, as outlined by @ryantxu at https://github.com/panodata/panodata-map-panel/issues/108.

However, we are still maintaining the canonical friendly fork of the original Worldmap panel on behalf of the Panodata Map Panel and would appreciate your contribution very much.

@daquinoaldo was so nice to submit https://github.com/grafana/worldmap-panel/pull/322 from his pen as https://github.com/panodata/panodata-map-panel/pull/117 just recently. Maybe you would like to join him on this?

With kind regards, Andreas.

P.S.: Some feedback/questions to the features this patch is adding to the code base. JFYI, I don't expect any answers if you don't feel like those pointers are related at all.

  1. Filtering data points with value lower than a number, set up on the editor screen.

Is this similar/related to the request at https://github.com/panodata/panodata-map-panel/issues/94 by @manupomax or even https://github.com/panodata/panodata-map-panel/issues/60 by @Dulanic?

  1. Using colour as a second metric, enabling the map to show two different metrics, like total bought pizzas and complaints, or sessions and errors.

Is this what @edornd requested at https://github.com/panodata/panodata-map-panel/issues/71#issuecomment-775846879? Please also note https://github.com/panodata/panodata-map-panel/pull/64 by @JonasProgrammer, which probably touches a similar space.

eduelias commented 3 years ago

Dear Eduardo,

this patch is very valuable. Thanks a stack for sharing it with the community.

For your records, Grafana Labs will probably move on to integrate the new "Geomap panel" into Grafana core, as outlined by @ryantxu at panodata#108.

However, we are still maintaining the canonical friendly fork of the original Worldmap panel on behalf of the Panodata Map Panel and would appreciate your contribution very much.

@daquinoaldo was so nice to submit #322 from his pen as panodata#117 just recently. Maybe you would like to join him on this?

With kind regards, Andreas.

P.S.: Some feedback/questions to the features this patch is adding to the code base. JFYI, I don't expect any answers if you don't feel like those pointers are related at all.

  1. Filtering data points with value lower than a number, set up on the editor screen.

Is this similar/related to the request at panodata#94 by @manupomax or even panodata#60 by @Dulanic?

  1. Using colour as a second metric, enabling the map to show two different metrics, like total bought pizzas and complaints, or sessions and errors.

Is this what @edornd requested at panodata#71 (comment)? Please also note panodata#64 by @JonasProgrammer, which probably touches a similar space.

Dear Andreas,

First, thanks for the kindness and attention, it's always a pleasure to deal with kind people such yourself! Here are my answers:

  1. Filtering data points with value lower than a number, set up on the editor screen.

Is this similar/related to the request at panodata#94 by @manupomax or even panodata#60 by @Dulanic?

No. Unfortunately, the filter only filters any metric under the defined unit. If you don't want to see circles where the value are <10, that will do it. Won't deal with percentages or thresholds.

  1. Using colour as a second metric, enabling the map to show two different metrics, like total bought pizzas and complaints, or sessions and errors.

Is this what @edornd requested at panodata#71 (comment)? Please also note panodata#64 by @JonasProgrammer, which probably touches a similar space.

Yes. Yes and yes. This splits up colour and diameter as two separate metrics and would solve those requests.

About the PR in general, I'm using this panel in a project and it would be amazing to have those functionalities coming directly from the official plugin. I discussed with my colleagues about the panomap and to shift to it now would bring us some trouble that we're not able to handle right now. We're excited to know that this amazing tool is going to be in grafana's Core and we would love to collaborate so those functionalities would be available when it comes.

Let me know how can I contribute more and what should I do to see this merged, if possible. Thanks! :D