search

grafana / xk6-amqp

A k6 extension for publishing and consuming messages from queues and exchanges using AMQP 0.9.1.
Apache License 2.0
25 stars 28 forks source link

Allow creating multiple connections and select which one to use #27

Closed swantzter closed 11 months ago

swantzter commented 1 year ago

fixes #24

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

swantzter commented 1 year ago

I tried to keep this non-breaking which in some cases resulted in an added positional argument that takes an options struct, but relies on existing options structs if they exist. But I'm open to other alternatives, even going to options arguments across the board and thus breaking the API

swantzter commented 11 months ago

@javaducky sorry for the delay, I was enjoying a vacation away from a proper computer :) think it should be sorted now

javaducky commented 11 months ago

@swantzter thank you! Looks like there are some linter issues related to missing documentation for the *.GetConn functions.

swantzter commented 11 months ago

@javaducky yeah I was looking at them, but I can't see how what I've done differs from how the rest of the library code does it, do you have any pointers for how to align it?