Implement `Page.waitForURL(url[, options])` - Githubissues

grafana / xk6-browser

k6 extension that adds support for browser automation and end-to-end web testing via the Chrome Devtools Protocol

https://grafana.com/docs/k6/latest/javascript-api/k6-experimental/browser/

GNU Affero General Public License v3.0

337 stars 42 forks source link

Implement `Page.waitForURL(url[, options])` #107

Open robingustafsson opened 2 years ago

robingustafsson commented 2 years ago

Add support for Page.waitForURL(url[, options]), to allow waiting for main fram navigation to specified URL.

Relevant links:

Playwright docs: https://playwright.dev/docs/next/api/class-page#page-wait-for-url
xk6-browser code for Page.waitForURL(url[, options]): https://github.com/grafana/xk6-browser/blob/main/common/page.go#L545
Playwright code: https://github.com/microsoft/playwright/blob/master/packages/playwright-core/src/client/frame.ts#L158
Playwright tests: https://github.com/microsoft/playwright/blob/master/tests/page/page-wait-for-url.spec.ts

imiric commented 2 years ago

@robingustafsson Why is this tagged with needs async? Isn't it essentially just another event we wait synchronously for?

We also need this functionality for #253, which is another API for the same functionality, I suppose. Should we close that one as duplicate and make it part of this issue?