inancgumus
commented
3 years ago I tried to add a test for the 1001 (going away) status. Let's keep it here only for reference.
func TestConnectionGoingAway(t *testing.T) {
const wantErr = "websocket: close 1001" // going away
done := make(chan struct{})
server := testutils.NewWSTestServer(t,
"/going-away",
http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {
conn, err := (&websocket.Upgrader{}).Upgrade(w, req, w.Header())
require.NoError(t, err)
conn.WriteControl(
websocket.CloseMessage,
websocket.FormatCloseMessage(websocket.CloseGoingAway, ""),
time.Now().Add(time.Second),
)
<-done
defer func() {
done <- struct{}{}
}()
var any interface{}
err = conn.ReadJSON(any)
require.ErrorContains(t, err, wantErr)
}))
defer server.ServerHTTP.Close()
url, _ := url.Parse(server.ServerHTTP.URL)
wsURL := fmt.Sprintf("ws://%s/going-away", url.Host)
ctx := context.Background()
conn, err := NewConnection(
ctx,
wsURL,
NewLogger(ctx, NullLogger(), false, nil),
)
require.NoError(t, err)
// close the connection before the client has a chance to read
// from it. this will result in a "going away" error.
conn.Close()
done <- struct{}{}
action := target.SetDiscoverTargets(true)
err = action.Do(cdp.WithExecutor(ctx, conn))
require.ErrorContains(t, err, wantErr)
<-done
}
elimatripathy
We've seen intermittent failures of
TestConnectionClosureAbnormal/closure_abnormalmostly in CI and ocasionally in local runs as well.The current test expects the error code
1006 (abnormal closure), but sometimes--typically under high load or in VMs running on overprovisioned hardware, as is usually the case for GH Actions--it will fail with code1001 (going away):We tried simply handling both cases in #33, but they're separate scenarios and the test should only fail with
1006as that's what the/closure-abnormalendpoint should cause.