search

grafana / xk6-browser

k6 extension that adds support for browser automation and end-to-end web testing via the Chrome Devtools Protocol
https://grafana.com/docs/k6/latest/javascript-api/k6-experimental/browser/
GNU Affero General Public License v3.0
337 stars 42 forks source link

Setting `screen` and `viewport` does not increase dimensions of browser window #68

Closed tom-miseur closed 2 years ago

tom-miseur commented 2 years ago 
context = browser.newContext({
    screen: {width: 1920, height: 1080},
    viewport: {width: 1920, height: 1080},
  });

This does increase the viewport dimensions, but I'm expecting (perhaps wrongly?) screen to refer to the browser window, which remains at the default 800x600.

robingustafsson commented 2 years ago

@tom-miseur This will be fixed as part of https://github.com/grafana/xk6-browser/pull/63.

inancgumus commented 2 years ago

I'm closing this issue as it doesn't regress anymore after #63.

imiric commented 2 years ago

@inancgumus Let's leave issues open until the actual PR is merged (I'm reviewing it right now). GitHub would've automatically closed this anyway.

No need to reopen it now, just in general. :)