grafana / xk6-client-prometheus-remote

A k6 extension for testing Prometheus Remote Write endpoints
Apache License 2.0
24 stars 12 forks source link

feat: update k6 dependency and go version #28

Closed fgouteroux closed 1 year ago

fgouteroux commented 1 year ago

Hello,

Since k6 version v0.42 this extension xk6-output-prometheus-remote is available within k6 as an experimental module. I made this PR to update the k6 dependency version to v0.45 and go version to 1.19.

So we can do this:


k6 run load-testing-remote-write.js -o experimental-prometheus-rw
javaducky commented 1 year ago

So we can do this:

k6 run load-testing-remote-write.js -o experimental-prometheus-rw

@fgouteroux , there may be some confusion with this particular extension. This extension (xk6-client-prometheus-remote) is for testing Prometheus remote write endpoints directly, i.e. testing Prometheus, DataDog, New Relic installations.

The xk6-output-prometheus-remote is the extension allowing k6 test metrics to be output to a Prometheus backend. It is this output extension that is invoked as an experimental module using the -o experimental-prometheus-rw argument to k6.

I hope this clears up any confusion on these similarly named extensions.

javaducky commented 1 year ago

This issue would address #29.

fgouteroux commented 1 year ago

So we can do this:


k6 run load-testing-remote-write.js -o experimental-prometheus-rw

@fgouteroux , there may be some confusion with this particular extension. This extension (xk6-client-prometheus-remote) is for testing Prometheus remote write endpoints directly, i.e. testing Prometheus, DataDog, New Relic installations.

The xk6-output-prometheus-remote is the extension allowing k6 test metrics to be output to a Prometheus backend. It is this output extension that is invoked as an experimental module using the -o experimental-prometheus-rw argument to k6.

I hope this clears up any confusion on these similarly named extensions.

Yes I know and this is what I want. Testing my mimir clusters and output the result into it. I use the grafana k6 dashboard as well and we can track our tests result.

fgouteroux commented 1 year ago

Hi @fgouteroux! Thank you for the update!

It looks like the bench_test.go no longer compiles with these changes. You can see this issue by running go test -cover -race ./.... Please correct the compilation issues and we'll reevaluate.

@javaducky fixed