grafana / xk6-disruptor

Extension for injecting faults into k6 tests

https://k6.io/docs/javascript-api/xk6-disruptor/

GNU Affero General Public License v3.0

91 stars 7 forks source link

Use default options in all e2e tests #317

Closed pablochacin closed 1 year ago

pablochacin commented 1 year ago

Description

In order to facilitate reusing the test cluster use default options in all e2e tests.

Checklist:

[X] I have performed a self-review of my code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works.
[X] I have run linter locally (make lint) and all checks pass.
[X] I have run tests locally (make test) and all tests pass.
[X] I have run relevant e2e test locally (make e2e-xxx for agent, disruptors, kubernetes or cluster related changes)
[ ] Any dependent changes have been merged and published in downstream modules

pablochacin commented 1 year ago

Wouldn't this cause issues if tests are (accidentally or not) started without E2E_REUSE=1? If this is the case, shouldn't E2E_REUSE become the default behavior?

The idea is that reusing should not be the default when running each test independently but when running a series of tests to speed up the process.

I think the actual behavior and options are the more sensible choice to cover these two use scenarios.