grafana / xk6-disruptor

Extension for injecting faults into k6 tests
https://k6.io/docs/javascript-api/xk6-disruptor/
GNU Affero General Public License v3.0
95 stars 7 forks source link

Move cluster package e2e tests to integration tests #341

Closed pablochacin closed 1 year ago

pablochacin commented 1 year ago

Description

Moves the cluster tests to the package as integration tests. The are no changes to the tests.

Checklist:

pablochacin commented 1 year ago

@roobre these tests do not use the e2e test framework at all. In fact, the cluster package is used by the e2e test framework.

The benefit is to separate the tests that actually use the e2e framework (basically, the disruptor test) from the tests that target one single component, like this one.

I have changed the name of the test clusters to avoid any reference to e2e, in case this may induce confusion.

roobre commented 1 year ago

Makes sense, I think what confused me was that both used kind-related things under the hood.

pablochacin commented 1 year ago

I think what confused me was that both used kind-related things under the hood.

The purpose of this package is to isolate the e2e tests from the actual test infrastructure we use (in this case, kind). So is not that they both use the same infrastructure but this cluster package provides the infrastructure to the e2e tests. The tests we are moving here just test the integration with kind.