grafana / xk6-disruptor

Extension for injecting faults into k6 tests

https://k6.io/docs/javascript-api/xk6-disruptor/

GNU Affero General Public License v3.0

89 stars 9 forks source link

Refactor agent controller #355

Closed pablochacin closed 10 months ago

pablochacin commented 10 months ago

Description

Refactor the code around the AgentController to improve the separation of concerns and facilitate testing by separating the logic that handles the management of a set of pods (PodController) from the logic that interacts with one agent (PodVisitor).

Also simplifies the API around the generation of the commands used for interacting with the pod agent.

Fixes: https://github.com/grafana/xk6-disruptor/issues/259

Checklist:

[X] I have performed a self-review of my code
[X] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X] I have added tests that prove my fix is effective or that my feature works.
[X] I have run linter locally (make lint) and all checks pass.
[X] I have run tests locally (make test) and all tests pass.
[X] I have run relevant integration test locally (make integration-xxx for affected packages)
[X] I have run relevant e2e test locally (make e2e-xxx for disruptors, or cluster related changes)
[ ] Any dependent changes have been merged and published in downstream modules