grafana / xk6-kubernetes

Client extension for interacting with Kubernetes clusters from your k6 tests.
Apache License 2.0
62 stars 20 forks source link

Use REST resource mapper #85

Closed toddtreece closed 1 year ago

toddtreece commented 1 year ago

Why

This is an attempt to add support for custom resources.

Related issues:

What

pablochacin commented 1 year ago

Hi @toddtreece Thanks for the PR. The changes look good to me.

javaducky commented 1 year ago

Awesome @toddtreece ! I'm just taking a look at it now.

pablochacin commented 1 year ago

I was able to install a CRD (K6 type from k6-operator) and perform CRUD operations successfully as well.

yay! It would be nice to add an example of using CRDs :thinking: I'm creating and issue for that.

Sorry that we have a ton of cruft in the examples directory...many can be ignored as we will be replacing most of them;

@javaducky maybe it is time to address this issue. Once we have a clear list of examples we want to maintain, I have some ideas of how to use them to implement #48 based on what I have been doing in xk6-disruptor.

pablochacin commented 1 year ago

@toddtreece I renamed the PR because the title was misleading. Even when the motivation of the PR is to support CRDs the scope is basically introduce the REST mapper. If the scope were to introduce support for CRDs then we should had to add examples and tests for that, what we haven't done in this PR.