search

grafana / xk6-output-prometheus-remote

k6 extension to output real-time test metrics using Prometheus Remote Write.
GNU Affero General Public License v3.0
152 stars 71 forks source link

Bug On HTTP Failed Request #152

Closed rodneyosodo closed 11 months ago

rodneyosodo commented 11 months ago

Description

There is a bug on getting failed requests for the grafana dashboard

Actual Bug

From this line https://github.com/grafana/xk6-output-prometheus-remote/blob/0afae1aea787965398ca62d07593d6498fecc43b/grafana/dashboards/k6-prometheus-native-histogram.json#L414C15-L414C15 is the query should be expected_response="true" which doesn't return failed requests

Suggestion

Change to expected_response="true"

ppcano commented 11 months ago

Fixed by #153.

@rodneyosodo, thanks for taking the time to report this issue.