grafana / xk6-output-prometheus-remote

k6 extension to output real-time test metrics using Prometheus Remote Write.
GNU Affero General Public License v3.0
156 stars 72 forks source link

dashboard: add code status rate and apdex, improvement checks, update… #98

Closed jwcastillo closed 1 year ago

jwcastillo commented 1 year ago

new dashboard version

add:

update:

remove:

codebien commented 1 year ago

Hey @jwcastillo, thanks for your contribution :bow:

@ppcano I assigned you as a reviewer so we have more opinions here

ppcano commented 1 year ago

Nice job, @jwcastillo.

I doubt whether to include the Apdex metric or not. Neither Grafana pre-built dashboards nor k6 Cloud present the Apdex score by default. Initially, we aim for consistency across OSS and commercial dashboards. @dgzlopes, wdyt?

dgzlopes commented 1 year ago

Yeah, lovely PR! Thanks for the work :heart:

I doubt whether to include the Apdex metric or not. Neither Grafana pre-built dashboards nor k6 Cloud present the Apdex score by default. Initially, we aim for consistency across OSS and commercial dashboards. @dgzlopes, wdyt?

I fully agree, it feels a bit out of place in this dashboard :+1:

jwcastillo commented 1 year ago

Ok I put it in a separate dashboard, like the custom metrics example

javaducky commented 1 year ago

Looks awesome!

codebien commented 1 year ago

I think we shouldn't document the dashboards here. It would be better if we update the official doc. I think in this repo we should only document stuff specifically for the extension, all the rest should stay on the k6-docs.

I would open a PR to drop all the current text of the README and structure a list of links plus the specific info for the extension. Similar to what @MattDodsonEnglish did for https://github.com/grafana/k6/blob/master/README.md.

@ppcano @javaducky WDYT?

ppcano commented 1 year ago

@codebien If the dashboards are now ready, I suggest merging the PR and we'll update the readme and the docs.