search

grafana / xk6-webcrypto

WIP implementation of the WebCrypto specification for k6
GNU Affero General Public License v3.0
7 stars 4 forks source link

Unify, format, and run tests against examples #77

Closed olegbespalov closed 7 months ago

olegbespalov commented 7 months ago

What?

Note that: import/export examples are commented on since they are actually catch a data race that should be resolved after #76

Sorry for the big PR. It's better to check by commit; the first commit could be skipped since it's auto-formating.

Why?

Unifying examples should improve the documentation and simplify their maintenance.

A pull-request starter https://github.com/grafana/xk6-webcrypto/pull/67#discussion_r1561013838

Running the tests against examples should help with finding degradations like https://github.com/grafana/xk6-webcrypto/pull/68

olegbespalov commented 7 months ago

@mstoykov FYI, after including import/export (data race has gone with #76 ), I've found that one of the examples become broken (:tada:) and I include a minor fix 445ad03 to this PR. Hope that works!

olegbespalov commented 7 months ago

@joanlopez Since this PR is mostly about auto-applying the eslint + moving things around, I'm going to merge it as it is (since I need a couple more based on it). If you have any other feedback, feel free to bring it, and I'll iterate on it separately with PRs if needed.