search

grafana / xk6-webcrypto

WIP implementation of the WebCrypto specification for k6
GNU Affero General Public License v3.0
7 stars 4 forks source link

Web Platform Tests Checkout #87

Closed olegbespalov closed 1 month ago

olegbespalov commented 1 month ago

What?

This PR implements running of the web platform tests not against static in-repository files, but it does check out to the latest proven to commit, apply patches with k6/web crypto implementation specific, and runs test against it.

It also brings tooling around, like easy checkout and patch generation.

Why?

This approach has proven successful in https://github.com/grafana/k6/pull/3696 and has many benefits. For example, we can clearly identify the difference between K6's and WPT test suites.

It also improves developer (and reviewer) UX.

Closes: #81

oleiade commented 1 month ago

I'll name @joanlopez for this review in my place if that's okay with you folks, as he drove this work on streams before and would likely have much more insights to offer than me 🙇🏻

olegbespalov commented 1 month ago

I would really prefer if every change has a comment on why we are doing this. Some do whcih is great, but some that seem "strange" do not and I wonder to what extend that is "this is not needed for us" and "we have not implemented something" or "we implemented something wrongly".

I do accept all the comments and will be happy to implement them, but probably as part of the following PR since I'd like to merge firstly this and RSA support. I will open take anyway :+1:

olegbespalov commented 1 month ago

@joanlopez I've merged to run the PRs train. Feel free to drop more feedback here since in any case, soon I'll open one more to address Mihails suggestions