search

grafeas / grafeas-pgsql

Grafeas with PostgreSQL backend
Apache License 2.0
14 stars 21 forks source link

Fix filtering #16

Closed brendin-nye closed 2 years ago

brendin-nye commented 2 years ago

Context

Filtering was implemented in pull request #11. In its current state, there is a small import error in filtering.go. Filtering implementation appears to assume JSON(B) for the data columns in notes and occurrences tables.

Description

This PR brings the filtering implementation into a working state by changing the import of expr to the one implemented in grafeas repo. data columns are changed to JSONB and database operation code in pgsqlstore.go is updated accordingly. Some dependency updates and fix some deprecation warnings with ptypes timestamp.Now().

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

brendin-nye commented 2 years ago

Woops, something went wrong with signing CLA, I'll get that fixed.

aethanol commented 2 years ago

cc @wkozlik @nyc ❤️